LIBCLOUD-572 internet-gateways-filters for ec2 driver #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint is failing, besides that, LGTM. /cc @cderamus |
|
Why is lint failing ? Is there anything I can fix ? |
|
Yes, just some trailing whitespace - https://travis-ci.org/apache/libcloud/jobs/26680711#L48 |
|
fixed |
|
Updated the code to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend EC2 driver ex_list_internet_gateways() method with ability to provide internet gateway ID and filters to list only specific internet gateways.